Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow trailing slash redirect to be disabled #2356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deer
Copy link
Contributor

@deer deer commented Mar 10, 2024

closes #2343

Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs and everything are really great! It's a very thorough PR 👍

One thing I'm wondering is if we should turn the trailingSlash option into a tri-state vs adding a second option. I haven't spent enough thinking on this, but I'm trying to come up with use cases where you'd for example want to have trailing slashes in your URL, but don't want to have the redirect. I might be missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to disable trailing slash logic
2 participants