Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: allow busybox unzip, 7z/7zz/7za, bsdtar #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erg
Copy link

@erg erg commented Jan 29, 2025

according to issue #172, busybox unzip is an alternative to installing unzip or 7z. (it works!)

also support 7zz, a standalone 7z build. and 7za, another binary name for 7z. and support bsdtar.

busybox is installed by default on Ubuntu 24.04.1 LTS but unzip/7z are not.

note: busybox is not installed on macOS 15.3 by default but unzip is.

see also bun repo for a similar pr. oven-sh/bun#16881

@erg erg force-pushed the install-sh-allow-busybox branch 2 times, most recently from 5b4d542 to 2f46582 Compare January 29, 2025 20:28
erg added a commit to erg/bun that referenced this pull request Jan 29, 2025
see denoland/deno_install#321 as well

This makes installing bun easier on systems where you don't have root.
@erg erg force-pushed the install-sh-allow-busybox branch 2 times, most recently from c687b48 to 0ae0cfd Compare January 29, 2025 21:40
erg added a commit to erg/bun that referenced this pull request Jan 29, 2025
see denoland/deno_install#321 as well

This makes installing bun easier on systems where you don't have root.
erg added a commit to erg/bun that referenced this pull request Jan 29, 2025
see denoland/deno_install#321 as well

This makes installing bun easier on systems where you don't have root.
erg added a commit to erg/bun that referenced this pull request Jan 29, 2025
see denoland/deno_install#321 as well

This makes installing bun easier on systems where you don't have root.
@erg
Copy link
Author

erg commented Jan 29, 2025

https://github.com/denoland/deno_install/actions/runs/13040968656/job/36382511316

macOS has a failing test. it looks like it's failing the shell check. Updating...

==> Fetching shellcheck
==> Downloading https://ghcr.io/v2/homebrew/core/shellcheck/blobs/sha256:ef742b6992cfcdcd7289718ac64b27174e421d29ce3ad9b81e1856349059b117
==> Pouring shfmt--3.10.0.arm64_sonoma.bottle.tar.gz
🍺  /opt/homebrew/Cellar/shfmt/3.10.0: 8 files, 2.8MB
==> Pouring shellcheck--0.10.0.arm64_sonoma.bottle.tar.gz
🍺  /opt/homebrew/Cellar/shellcheck/0.10.0: 8 files, 66.7MB
diff install.sh.orig install.sh
--- install.sh.orig
+++ install.sh
@@ -4,7 +4,7 @@
 
 set -e
 
-if ! command -v unzip >/dev/null && ! command -v busybox unzip > /dev/null && ! command -v 7z >/dev/null && ! command -v 7zz > /dev/null; then
+if ! command -v unzip >/dev/null && ! command -v busybox unzip >/dev/null && ! command -v 7z >/dev/null && ! command -v 7zz >/dev/null; then
 	echo "Error: either unzip or busybox unzip or 7z or 7zz are required to install Deno (see: https://github.com/denoland/deno_install#either-unzip-or-7z-is-required )." 1>&2
 	exit 1
 fi
Error: Process completed with exit code 1.

@erg erg force-pushed the install-sh-allow-busybox branch 2 times, most recently from 064a242 to 096c6a9 Compare January 29, 2025 23:19
according to issue denoland#172, `busybox unzip` is an alternative to
installing unzip or 7z.

7zz is a standalone build of 7z

busybox is installed by default on Ubuntu 24.04.1 LTS but unzip/7z are not.

note: busybox is not installed on macOS 15.3 by default but unzip is.
@erg erg force-pushed the install-sh-allow-busybox branch from 096c6a9 to b33c3ef Compare January 30, 2025 05:54
erg added a commit to erg/bun that referenced this pull request Jan 30, 2025
see denoland/deno_install#321 as well

This makes installing bun easier on systems where you don't have root.
erg added a commit to erg/bun that referenced this pull request Jan 30, 2025
see denoland/deno_install#321 as well

This makes installing bun easier on systems where you don't have root.
@erg erg changed the title install: allow busybox unzip install: allow busybox unzip, 7z/7zz/7za, bsdtar Jan 30, 2025
erg added a commit to erg/bun that referenced this pull request Jan 30, 2025
see denoland/deno_install#321 as well

This makes installing bun easier on systems where you don't have root.
erg added a commit to erg/bun that referenced this pull request Jan 30, 2025
see denoland/deno_install#321 as well

This makes installing bun easier on systems where you don't have root.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant