Improve property configuration #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code may have no problems to work with Symfony 7, so we allow this dependency for now. The same goes for `php-parser` and `phpunit`. `phpdocumentator` can be removed, as this is not the proper way to install it to generate documentation. Instead a decoupled executable is to be used.
This commit attempts to solve the concerns in the referenced issue. A follow-up commit will be necessary to bring this work closer to completion. Refs: #115
Continue to solve the concerns in the referenced issue. Replacement of all behavior factories with static `createFactory` methods in the corresponding behavior implementation was not possible, because their parent interfaces require typehinting, that can not be done using anonymous classes. Maybe after the removal of `TCondition` and `TSorting` it becomes possible to remove additional factories, but other will need to remain. Refs: #115
These are initial, but relatively complete versions. To open/edit them UMLet is needed. Properly integrating them into the documentation articles is intended to be done at some point.
# Conflicts: # CHANGELOG.md # composer.json # docs/README.adoc # phpstan.neon
To reduce compatibility breaking changes, the previously replaced methods were added again, but marked as deprecated. A template parameter was adjusted as well. Neither having it defined in the method nor having it defined in the class docblock seem correct. This needs to be investigated further for all behavior factory classes, but for now the (understandable) concern was added to the phpstan baseline of concerns. Refs: #115
Instead of coupling the `AbstractResourceType` to some kind of configuration instance, we instead prepare it to be a configuration itself. To do so, we leave it to extending classes to provide behaviors like readability or updatability and remove the abstract `getResourceConfig` that so far provided these. Refs: #115
To reduce compatibility breaking changes, the previously replaced method was added again, but marked as deprecated. A template parameter was adjusted as well. Neither having it defined in the method nor having it defined in the class docblock seem correct. This needs to be investigated further for all behavior factory classes, but for now the (understandable) concern was added to the phpstan baseline of concerns. Refs: #115
* Typehint with interfaces instead of `callable` * improve documentation wording * add `removeAliasedPath` method Refs: #115
Passing and using a config builder as relationship type (as shown in the README.adoc) does only work if we postpone actually requiring the relationship type. E.g. if the config builder for `Book` resources references authors and the authors have a reference to the books, then on building the `Book` config builder it needs the `Author` relationship type from the `Author` config builder, so the author config needs to be build too, which in turn requires the `Book` config builder to be build first. By not requiring the actual relationship resource type when building, but a provider instead, all the configs can be build first and only when the relationship type is actually needed for some task it is requested from the provider. Keeping the possibility to initialize relationship config builders from the actual relationship still works outside of the context of resource config builders, e.g. when only using schema config builders. Refs: #115
Allows to configure a resource type without having to create a resource type class. Refs: #115
Current state still untested. Refs: #115
Config-builder classes are to be refactored to be simply configs, from which type instances can be created. Naming the method to retrieve such types `getType` instead of `getConfig` makes more sense. The interface names were adjusted accordingly.
Do not release `addConstructorCreationBehavior` with a constructor behavior as parameter. There should be a single `addCreationBehavior` taking a behavior factory that may (or may not) execute the constructor behavior as well as the post-constructor behavior. `addConstructorBehavior` will be kept for backward compatibility for now. Refs: #115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.