chore(refs T34290): **breaking** Always display Messages on api responses

CHANGELOG.md

@@ -4,6 +4,12 @@ Since v0.0.10, this Changelog is formatted according to the [Common Changelog][c
 
 ## UNRELEASED
 
+### Changed
+
+- ([#686](https://github.com/demos-europe/demosplan-ui/pull/686)) **breaking** add checkResponse to doRequest,
+  so it gets called every time a api request is fired.
+  It now must not be added in the leading app after using dpApi or dpRpc to avoid doubled messages
+
 ## v0.3.26 - 2024-07-30
 
 ### Fixed

src/lib/DpApi.js

@@ -75,10 +75,16 @@ const doRequest = (async ({ method = 'GET', url, data = {}, headers, params }) =
       ? await response.text()
       : null
 
-    return {
+    const returnData = await checkResponse({
       data: content,
-      status: response.status,
       ok: response.ok,
+      status: response.status
+    }, options.messages || null)
+
+    return {
+      data: returnData,
+      ok: response.ok,
+      status: response.status,
       statusText: response.statusText,
       url: response.url
     }
@@ -179,7 +185,9 @@ const checkResponse = function (response, messages) {
        */
     } else if (dplan !== undefined && dplan.debug && hasOwnProp(response, 'errors') && hasOwnProp(response, 'meta') && hasOwnProp(response.meta, 'messages')) {
       handleResponseMessages(response.meta)
-    } else if (messages && hasOwnProp(messages, response.status)) {
+    }
+
+    if (messages && hasOwnProp(messages, response.status)) {
       /*
        * The generic api (/api/2.0/{resourceType}) does not specify success messages.
        * Instead, custom messages passed by the calling component are displayed here.
@@ -188,7 +196,7 @@ const checkResponse = function (response, messages) {
     }
 
     if (response.status >= 400) {
-      // @improve handle 404, 500 specially?
+      // handle error cases
       reject(response.data)
     } else if (response.status >= 200 && response.status < 400) {
       // Got data!