chore(refs T34290): **breaking** Always display Messages on api responses #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nses until now, this has to be handled by the parent system. But to not forget to use it, checkResponse should always be called.
# Conflicts: # src/lib/DpApi.js
spiess-demos
requested changes
Oct 11, 2024
| ok: response.ok, | ||
| status: response.status | ||
| }, options.messages || null) |
There was a problem hiding this comment.
Where does this "options" come from? Seems like it got removed in the signature of doRequest in a recent refactoring, and this was not updated accordingly.
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until now, this has to be handled by the parent system. But to not forget to use it, checkResponse should always be called.
When releasing this, make sure, that in demosplan-core all ocurences of
checkResponseare removed.