Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5 🎫: Login page #18

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Issue #5 🎫: Login page #18

merged 1 commit into from
Dec 19, 2023

Conversation

ITurres
Copy link
Collaborator

@ITurres ITurres commented Dec 19, 2023

Pull Request Summary for Issue #5 Completion


Added:

  • N/A

Modified:

/app/views/devise/sessions/new.html.erb

  • I have modified the markup and styling of the login page to match the rest of the application.

Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres for any queries or further assistance. 🌟

@ITurres ITurres self-assigned this Dec 19, 2023
@ITurres ITurres linked an issue Dec 19, 2023 that may be closed by this pull request
@ITurres ITurres added enhancement New feature or request UI Views and Interfaces good first issue Good for newcomers and removed good first issue Good for newcomers labels Dec 19, 2023
Copy link
Owner

@demesameneshoa demesameneshoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED ✔️ ✔️

Hi @ITurres,

✔️ User Sign In View Deployed

Your ticket is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me with @demesameneshoa in your question so I can receive the notification.

@ITurres ITurres merged commit 9656ac1 into dev Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI Views and Interfaces
Projects
Development

Successfully merging this pull request may close these issues.

[2pt] - Login Page
2 participants