Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Title update #49

Merged
merged 4 commits into from
Sep 24, 2024
Merged

chore: Title update #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27ded21
Updating date and other outdated text items
kabirsg Sep 23, 2024
0e6f9a1
Merge branch 'main' of https://github.com/deltahacks/landing-10
kabirsg Sep 23, 2024
cd6ad6e
Updating website title
kabirsg Sep 24, 2024
e14583b
Merge branch 'main' into title-update
kabirsg Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/CarouselWrapper.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const images: ReactImageGalleryItem[] = await Promise.all(
originalAlt:
"A wide-angle view of a packed lecture hall with rows of students seated at desks, some with raised hands, engaging with a presenter speaking at the front.",
description:
"With over 500 attendees last year, DeltaHacks 10 is shaping up to be the biggest one yet!",
"With over 500 attendees last year, DeltaHacks 11 is shaping up to be the biggest one yet!",
},
{
image: DSC01770,
Expand Down
2 changes: 1 addition & 1 deletion src/components/Hero.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const { id } = Astro.props;
<!-- RGBA(19, 77, 84, 1) -->

<div
class="z-10 flex w-full flex-col gap-4 text-center text-xl font-semibold sm:w-3/4 sm:flex-row lg:w-1/2"
class="z-10 flex w-full flex-col gap-4 text-center text-xl font-semiboldsm:w-3/4 sm:flex-row lg:w-1/2"
>
<!-- <a
href="https://portal.deltahacks.com/"
Expand Down
6 changes: 3 additions & 3 deletions src/layouts/main.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,21 @@ import "@fontsource/poppins/700.css";
}

<!-- HTML Meta Tags -->
<title>DeltaHacks 10</title>
<title>DeltaHacks</title>
<meta name="description" content="The hackathon for change." />

Comment on lines 27 to 28
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider enhancing meta descriptions and dynamically setting image URLs.

While updating the titles, consider the following improvements:

  1. The description meta tag currently uses a generic message. Consider making it more specific to DeltaHacks, possibly including the year or any unique aspects of the current event.

  2. The image meta tags use a static image URL. If the event branding changes yearly, consider implementing a dynamic way to set these URLs, ensuring they always reflect the current event's branding.

Example of a more specific description:

<meta name="description" content="DeltaHacks: The annual hackathon for change at McMaster University. Join us for 24 hours of innovation, coding, and making a difference." />

For dynamic image URLs, consider using a variable or config file to set the current year's image:

<meta property="og:image" content={`https://deltahacks.com/meta-${currentYear}.png`} />

Also applies to: 33-35, 41-43

<!-- Facebook Meta Tags -->
<meta property="og:url" content="https://deltahacks.com/" />
<meta property="og:type" content="website" />
<meta property="og:title" content="DeltaHacks 10" />
<meta property="og:title" content="DeltaHacks" />
<meta property="og:description" content="The hackathon for change." />
<meta property="og:image" content="https://deltahacks.com/meta.png" />

<!-- Twitter Meta Tags -->
<meta name="twitter:card" content="summary_large_image" />
<meta property="twitter:domain" content="deltahacks.com" />
<meta property="twitter:url" content="https://deltahacks.com/" />
<meta name="twitter:title" content="DeltaHacks 10" />
<meta name="twitter:title" content="DeltaHacks" />
<meta name="twitter:description" content="The hackathon for change." />
<meta name="twitter:image" content="https://deltahacks.com/meta.png" />

Expand Down
Loading