Sarahsimionescu/tech 24 sponsors

[sarahsimionescu]

No description provided.

[linear]

TECH-24 Sponsors

grid - add sponsors as the sponsorship team informs the tech team

[netlify]

✅ Deploy Preview for elaborate-croquembouche-906522 ready!

Name	Link
🔨 Latest commit	d065b89
🔍 Latest deploy log	https://app.netlify.com/sites/elaborate-croquembouche-906522/deploys/651af542b04c8f000811be2c
😎 Deploy Preview	https://deploy-preview-3--elaborate-croquembouche-906522.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[sarahsimionescu]

WHaa

[sarahsimionescu]

plz help @err53 @Krish120003

[err53]

@sarahsimionescu added sharp so it builds, still gotta fix file formatting (also can we use a placeholder that's not so undersized?)

[err53]

or even just don't put placeholders for now idk

[sarahsimionescu]

Sure! How can I satisfy the rest of the checks?

[err53]

Sure! How can I satisfy the rest of the checks?

1. Looks like src/components/Sponsors.astro isn't properly formatted, run the VSCode format code command on it
2. For the lighthouse lint, there's not much we can do right now, since we don't have all the sponsorship images. I'd recommend commenting out the placeholders for now, since it clearly works in the preview, and we'll need to change spacing based on the final received images anyways.

[err53]

Oh yeah, feel free to remove the colour override in for the bg, we plan to cover that in global styling instead (or merge the changes from the base theme branch anyways

[sarahsimionescu]

1. fixed
2. also fixed
   Let me know if there is anything else I should do! @err53

[err53]

Ok, 2 more things that should be fixed before merging:

3. Currently we're not resizing images for different screen sizes which is not optimal, I just pushed some code that should enable that, please implement this for all other images. Use this tool to find the right sizes string for each image: https://ausi.github.io/respimagelint/
4. We're currently hard-coding each row, which isn't the best solution. Would it be possible to use a single 12-column wide grid, use col-span for each element in your array, and then use a for loop to iterate through each element in the list? This should significantly improve the readability and maintainability of the code. See: https://tailwindcss.com/docs/grid-column

[err53]

@sarahsimionescu fixed your grid code to work programatically

[err53]

Merge Activity

• Oct 2, 12:54 PM: @err53 merged this pull request with Graphite.