Feat/automation switch #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add warning state & compare credential id with gx:dependsOn to filter out the correct ID * chore: rename matchverifiable to isIdMatchVerifiable, update Badge and verifyRawServiceCredential function * fix: update isIdMatchVerifiable type to string and adjust related logic in Badge and verifyRawServiceCredential * refactor: remove console.log * refactor: correct casing in setIsIdMatchVerifiable * refactor: simplify return structure in verifyRawServiceCredential to use a constant for verified & complianceApiVersion and update dependsOnIds * fix: update isWarning condition to check length of isIdMatchVerifiable in Badge component * fix: update condition to check for empty rootService array in verifyRawServiceCredential * refactor: store credentialSubject in a constant for improved readability in verifyRawServiceCredential * fix: update idMatch condition to check for both original and lowercase DID in verifyRawServiceCredential
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
moritzkirstein
requested changes
Jan 30, 2025
moritzkirstein
force-pushed
the
development
branch
from
baf7cd9 to
82b7b1a
Compare
|
once tests are fixed and all checks pass this is good to go imo! |
moritzkirstein
approved these changes
Jan 30, 2025
moritzkirstein
pushed a commit
that referenced
this pull request
Feb 3, 2025
* feat: check credential ID match warning (#634) * feat: add warning state & compare credential id with gx:dependsOn to filter out the correct ID * chore: rename matchverifiable to isIdMatchVerifiable, update Badge and verifyRawServiceCredential function * fix: update isIdMatchVerifiable type to string and adjust related logic in Badge and verifyRawServiceCredential * refactor: remove console.log * refactor: correct casing in setIsIdMatchVerifiable * refactor: simplify return structure in verifyRawServiceCredential to use a constant for verified & complianceApiVersion and update dependsOnIds * fix: update isWarning condition to check length of isIdMatchVerifiable in Badge component * fix: update condition to check for empty rootService array in verifyRawServiceCredential * refactor: store credentialSubject in a constant for improved readability in verifyRawServiceCredential * fix: update idMatch condition to check for both original and lowercase DID in verifyRawServiceCredential * chore: remove code coverage workflow (#628) * feat: add automation switch and conditional rendering * feat: enable conditional rendering for automation context based on app config
moritzkirstein
pushed a commit
that referenced
this pull request
Feb 6, 2025
* feat: check credential ID match warning (#634) * feat: add warning state & compare credential id with gx:dependsOn to filter out the correct ID * chore: rename matchverifiable to isIdMatchVerifiable, update Badge and verifyRawServiceCredential function * fix: update isIdMatchVerifiable type to string and adjust related logic in Badge and verifyRawServiceCredential * refactor: remove console.log * refactor: correct casing in setIsIdMatchVerifiable * refactor: simplify return structure in verifyRawServiceCredential to use a constant for verified & complianceApiVersion and update dependsOnIds * fix: update isWarning condition to check length of isIdMatchVerifiable in Badge component * fix: update condition to check for empty rootService array in verifyRawServiceCredential * refactor: store credentialSubject in a constant for improved readability in verifyRawServiceCredential * fix: update idMatch condition to check for both original and lowercase DID in verifyRawServiceCredential * chore: remove code coverage workflow (#628) * feat: add automation switch and conditional rendering * feat: enable conditional rendering for automation context based on app config
moritzkirstein
pushed a commit
that referenced
this pull request
Feb 13, 2025
* feat: check credential ID match warning (#634) * feat: add warning state & compare credential id with gx:dependsOn to filter out the correct ID * chore: rename matchverifiable to isIdMatchVerifiable, update Badge and verifyRawServiceCredential function * fix: update isIdMatchVerifiable type to string and adjust related logic in Badge and verifyRawServiceCredential * refactor: remove console.log * refactor: correct casing in setIsIdMatchVerifiable * refactor: simplify return structure in verifyRawServiceCredential to use a constant for verified & complianceApiVersion and update dependsOnIds * fix: update isWarning condition to check length of isIdMatchVerifiable in Badge component * fix: update condition to check for empty rootService array in verifyRawServiceCredential * refactor: store credentialSubject in a constant for improved readability in verifyRawServiceCredential * fix: update idMatch condition to check for both original and lowercase DID in verifyRawServiceCredential * chore: remove code coverage workflow (#628) * feat: add automation switch and conditional rendering * feat: enable conditional rendering for automation context based on app config
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
app.config.js