fix: link to asset terms (#661)

* fix: update asset terms and conditions wording and handling in forms * fix: simplify options and actions handling in TermsAndConditionsCheckbox * refactor: rename 'actions' to 'licence' in TermsAndConditionsCheckbox and update handling * fix: correct spelling of 'licence' to 'license' in TermsAndConditionsCheckbox and related components * fix: update 'license' to 'licenses' in TermsAndConditionsCheckbox and related components
deltaDAO · Feb 13, 2025 · 7b521d0 · 7b521d0
1 parent bc31c1d
commit 7b521d0
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 14 deletions.
diff --git a/content/pages/startComputeDataset.json b/content/pages/startComputeDataset.json
@@ -26,8 +26,8 @@
     },
     "assetTermsAndConditions": {
       "name": "assetTermsAndConditions",
-      "options": ["Asset Terms and Conditions"],
-      "prefixes": ["I agree to the"]
+      "prefixes": ["I acknowledge that the asset is made available under"],
+      "postfixes": ["license and agree to the terms"]
     }
   }
 }
diff --git a/content/pages/startDownloadDataset.json b/content/pages/startDownloadDataset.json
@@ -7,8 +7,8 @@
     },
     "assetTermsAndConditions": {
       "name": "assetTermsAndConditions",
-      "options": ["Asset Terms and Conditions"],
-      "prefixes": ["I agree to the"]
+      "prefixes": ["I acknowledge that the asset is made available under"],
+      "postfixes": ["license and agree to the terms"]
     }
   }
 }
diff --git a/src/components/Asset/AssetActions/Compute/FormComputeDataset.tsx b/src/components/Asset/AssetActions/Compute/FormComputeDataset.tsx
@@ -397,7 +397,7 @@ export default function FormStartCompute({
       />
       <TermsAndConditionsCheckbox
         {...content.form.portalTermsAndConditions}
-        actions={[appConfig.defaultTermsAndConditionsUrl]}
+        licenses={[appConfig.defaultTermsAndConditionsUrl]}
         disabled={isLoading}
         onChange={() =>
           setPortalTermsAndConditions(
@@ -407,7 +407,7 @@ export default function FormStartCompute({
       />
       <TermsAndConditionsCheckbox
         {...content.form.assetTermsAndConditions}
-        actions={[asset?.metadata?.license]}
+        licenses={[asset?.metadata?.license]}
         disabled={isLoading}
         onChange={() =>
           setAssetTermsAndConditions(

diff --git a/src/components/Asset/AssetActions/Download/index.tsx b/src/components/Asset/AssetActions/Download/index.tsx
@@ -333,12 +333,12 @@ export default function Download({
                 )}
                 <TermsAndConditionsCheckbox
                   {...content.form.portalTermsAndConditions}
-                  actions={[defaultTermsAndConditionsUrl]}
+                  licenses={[defaultTermsAndConditionsUrl]}
                   disabled={isLoading}
                 />
                 <TermsAndConditionsCheckbox
                   {...content.form.assetTermsAndConditions}
-                  actions={[asset?.metadata?.license]}
+                  licenses={[asset?.metadata?.license]}
                   disabled={isLoading}
                 />
               </div>

diff --git a/src/components/Asset/AssetActions/TermsAndConditionsCheckbox.tsx b/src/components/Asset/AssetActions/TermsAndConditionsCheckbox.tsx
@@ -4,26 +4,34 @@ import styles from './index.module.css'
 
 export default function TermsAndConditionsCheckbox({
   name,
-  actions,
+  licenses,
   onChange,
   disabled,
   options,
-  prefixes
+  prefixes,
+  postfixes
 }: {
   name: string
-  actions: any
+  licenses: string[]
   onChange?: (termsAndConditions: boolean) => void
   disabled: boolean
-  options: string[]
+  options?: string[]
   prefixes: string[]
+  postfixes?: string[]
 }) {
   return (
     <Field
       name={name}
       type="checkbox"
-      options={options}
+      options={
+        options ||
+        licenses.map((option) =>
+          option.includes('http') ? 'a custom' : `the ${option}`
+        )
+      }
       prefixes={prefixes}
-      actions={actions}
+      postfixes={postfixes}
+      actions={licenses?.filter((action) => action.includes('http'))}
       component={Input}
       disabled={disabled}
       {...(onChange && { onChange })}