Added Tree quotas support for Powerflex #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KshitijaKakde
changed the title
khareRajshree
requested changes
Jul 20, 2023
| @@ -0,0 +1,77 @@ | |||
| package goscaleio | |||
There was a problem hiding this comment.
Please add the copyright section for this file.
types/v1/types.go
Outdated
| HardLimit int `json:"hard_limit,omitempty"` | ||
| SoftLimit int `json:"soft_limit,omitempty"` | ||
| IsUserQuotaEnforced bool `json:"is_user_quotas_enforced,omitempty"` | ||
| GracePeroid int `json:"grace_period,omitempty"` |
There was a problem hiding this comment.
typo --> "GracePeriod". Also check if any related instance needs to be updated.
types/v1/types.go
Outdated
| HardLimit int `json:"hard_limit,omitempty"` | ||
| SoftLimit int `json:"soft_limit,omitempty"` | ||
| IsUserQuotaEnforced bool `json:"is_user_quotas_enforced,omitempty"` | ||
| GracePeroid int `json:"grace_period,omitempty"` |
There was a problem hiding this comment.
typo --> "GracePeriod"
types/v1/types.go
Outdated
| HardLimit int `json:"hard_limit,omitempty"` | ||
| SoftLimit int `json:"soft_limit,omitempty"` | ||
| IsUserQuotasEnforced bool `json:"is_user_quotas_enforced,omitempty"` | ||
| GracePeroid int `json:"grace_period,omitempty"` |
There was a problem hiding this comment.
typo --> "GracePeriod"
khareRajshree
approved these changes
Jul 21, 2023
ashleyvjoy
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tree quota support for powerflex
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Integration Test
Unit Test
