Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFS: expand filesystem operation added #68

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

khareRajshree
Copy link
Contributor

Description

Expand NFS filesystem operation added.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#763

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • unit tests
=== RUN   TestCreateFileSystem
=== RUN   TestCreateFileSystem/success
=== RUN   TestCreateFileSystem/bad_request
--- PASS: TestCreateFileSystem (0.00s)
    --- PASS: TestCreateFileSystem/success (0.00s)
    --- PASS: TestCreateFileSystem/bad_request (0.00s)
=== RUN   TestDeleteFileSystem
--- PASS: TestDeleteFileSystem (0.00s)
=== RUN   TestModifyFileSystem
=== RUN   TestModifyFileSystem/#00
=== RUN   TestModifyFileSystem/#01
--- PASS: TestModifyFileSystem (0.00s)
    --- PASS: TestModifyFileSystem/#00 (0.00s)
    --- PASS: TestModifyFileSystem/#01 (0.00s)
  • integration tests
=== RUN   TestGetAllFileSystems
--- PASS: TestGetAllFileSystems (0.29s)
=== RUN   TestGetFileSystemByIDName
--- PASS: TestGetFileSystemByIDName (0.31s)
=== RUN   TestGetFileSystemByNameIDInvalid
--- PASS: TestGetFileSystemByNameIDInvalid (0.29s)
=== RUN   TestCreateDeleteFileSystem
--- PASS: TestCreateDeleteFileSystem (13.86s)
=== RUN   TestModifyFileSystem
--- PASS: TestModifyFileSystem (11.06s)

Copy link
Contributor

@VamsiSiddu-7 VamsiSiddu-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see the struct for type fsModify . Please create the struct for fsModify

@khareRajshree
Copy link
Contributor Author

I did not see the struct for type fsModify . Please create the struct for fsModify

Added in the latest commit, thanks.

@khareRajshree khareRajshree merged commit b67372e into main Jul 7, 2023
3 checks passed
@shanmydell shanmydell deleted the nfs-expand-fs branch October 16, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants