Update CSM-Replication module #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chimanjain
requested review from
adarsh-dell,
AkshaySainiDell,
bharathsreekanth,
harishp8889,
JacobGros,
Prabhu-Dell,
rajkumar-palani,
khareRajshree,
shefali-malhotra,
panigs7,
tssushma,
gilltaran,
shanmydell,
alikdell,
atye,
coulof,
shaynafinocchiaro,
xuluna and
EvgenyUglov
adarsh-dell
approved these changes
Aug 5, 2024
adarsh-dell
reviewed
Aug 5, 2024
| @@ -2,12 +2,10 @@ module github.com/dell/cert-csi | |||
|
|
|||
| go 1.22.0 | |||
|
|
|||
| toolchain go1.22.5 | |||
There was a problem hiding this comment.
Any impact from removing this toolchain?
There was a problem hiding this comment.
I hope you have tried to build the binary and use it for some basic sanity before raising the PR.
There was a problem hiding this comment.
No, if we don't mention toolchain, it will take the default go version present in our machine.
There was a problem hiding this comment.
I have build the binary successfully.
There was a problem hiding this comment.
I can see https://github.com/dell/cert-csi/blob/0233a8536958961763bc4d2e1b5dd5e320d6f7f0/Makefile#L55 so for docker image it should be fine.
Thanks for the confirmation.
AkshaySainiDell
approved these changes
Aug 5, 2024
chimanjain
force-pushed
the
update-rep-module
branch
from
15bc729
to
ea4d55a
Compare
tdawe
pushed a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update CSM-Replication module
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration