Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the --attr format for Ephemeral test suite #32

Merged
merged 0 commits into from
Aug 9, 2023

Conversation

adarsh-dell
Copy link
Contributor

@adarsh-dell adarsh-dell commented Aug 9, 2023

Description

Fixed the arg --attr format for ephemeral test suite to keep args format same for both functional and performance suite.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#930

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Run ephemeral test suite by passing fileName as a value to the --attr args and the suites passes as per the expectation.
    ./cert-csi test ephemeral-volume --driver csi-powerstore.dellem c.com --fs-type ext4 --attr attr-file --pods 5 --pod-name wrephe
    image

Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adarsh-dell adarsh-dell merged this pull request into main Aug 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants