This repository has been archived by the owner on Feb 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
chore!: add containerization and packaging manifest lints #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 20, 2024
✅ Deploy Preview for leapfrogai-docs canceled.
|
Instead of using an outdated and/or sketchy helm-lint action use this to manually install helm v3.15.1 and manually perform a |
Blocked by #920 |
42ffbd5
to
fac06e9
Compare
jalling97
reviewed
Sep 9, 2024
jalling97
reviewed
Sep 9, 2024
jalling97
previously approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job cleaning things up!
jalling97
previously approved these changes
Sep 9, 2024
some awesome cleanup, ty justin. I didn't review the code closely, but thanks for giving the thorough changelog. This is all great stuff in making the "ux" of contributing and deploying lfai better |
All changes completed and explanations reviewed by others
Merge this one in first: #977 Then merge with main and change e2e registry1 weekly to point to the commit SHA as a result of the above merge. |
CollectiveUnicorn
approved these changes
Sep 10, 2024
jalling97
approved these changes
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds linting for Helm, Docker, Zarf, and UDS manifests to improve the quality and consistency of all containerization and Kubernetes related logic.
Adds workflows and pre-commits to ensure consistency before and after committing to a PR.
Remaining lower-priority Dockerfile lint errors are in issue #984
BREAKING CHANGES
GPU_CLASS_NAME
is nowGPU_RUNTIME
to better align with the actual manifest spec field and purposeCHANGES
upstream-values.yaml
)v0.14.0
values.yaml
with default values, for UDS overrides following UDS Core patternsenv
variables to values filesGPU_ENABLED
python code/env from llama-cpp-pythonGPU_ENABLED
via values nor Zarf variables0
anyway, with no kosher way to change ite2e_registry1_weekly
test on draft PRs (mostly to stop it from running here all the time)check-merge-conflict
pre-commitclean
Make target for build artifact cleaning0.12.2
Related Issue
Fixes #965 #706 #705 #367 #365
Checklist before merging