This repository has been archived by the owner on Feb 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
chore(sdk, api): fix types, enhance chat, audio and completion tests #1038
Merged
justinthelaw
merged 107 commits into
main
from
1037-testvllm-implement-e2e-testing-for-vllm
Sep 20, 2024
Merged
chore(sdk, api): fix types, enhance chat, audio and completion tests #1038
justinthelaw
merged 107 commits into
main
from
1037-testvllm-implement-e2e-testing-for-vllm
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leapfrogai-docs canceled.
|
There seems to be an issue with our GPU runner configurations that is blocking the vLLM E2E tests from running: https://github.com/defenseunicorns/leapfrogai/actions/runs/10894219888/job/30230952202 The upstream UDS Common action is unable to install UDS CLI into the bin directory. It seems like it needs |
…nt-e2e-testing-for-vllm
70f58ad
to
a1a03c1
Compare
cac0fdb
to
3387974
Compare
Blocked until #1085 is merged into main. |
gphorvath
reviewed
Sep 20, 2024
justinthelaw
commented
Sep 20, 2024
justinthelaw
commented
Sep 20, 2024
CollectiveUnicorn
approved these changes
Sep 20, 2024
YrrepNoj
approved these changes
Sep 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates and enables vLLM E2E tests that touch each SDK gRPC endpoint at least once with a "happy path" test. Standardizes the new
Completions
test from vLLM's E2E tests to the LLaMA-CPP-Python E2E tests. Fixes theFinishReason
enum
typing andobject
field issues acrossCompletions
andChatCompletions
. AddsAudio
unit tests and refactors Repeater to enable running those tests.BREAKING CHANGES
FinishReason
to be an enum in both Completions and ChatCompletions protobufsEnum
class to define and transform the stub responsesobject
andcreated
field forCompletions
type as defined in the OpenAI API specificationtext_completion
forobject
ChatCompletions
type'screated
forCompletions
created
CHANGES
FinishReason
being the wrong typeRelated Issue
Fixes #1037
Relates to #854
Checklist before merging