fix KeyError in init_reaction #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix deepmodeling#1351. The old code seems to be wrong. While the old dispatcher has been entirely removed, the code can be more simple. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #1352 +/- ##
=======================================
Coverage 48.61% 48.61%
=======================================
Files 83 83
Lines 14694 14694
=======================================
Hits 7144 7144
Misses 7550 7550
☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1351.
The old code seems to be wrong. Since the old dispatcher has been entirely removed, the code can be more simple.