Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] The process of deepmd_version needs to be updated #1688

Closed
njzjz opened this issue Dec 15, 2024 · 0 comments · Fixed by #1691
Closed

[BUG] The process of deepmd_version needs to be updated #1688

njzjz opened this issue Dec 15, 2024 · 0 comments · Fixed by #1691
Labels
bug Something isn't working

Comments

@njzjz
Copy link
Member

njzjz commented Dec 15, 2024

Bug summary

Several codes like below needs to be updated.

dpgen/dpgen/generator/run.py

Lines 475 to 477 in e02e6a2

elif Version(mdata["deepmd_version"]) >= Version("2") and Version(
mdata["deepmd_version"]
) < Version("3"):

dpgen/dpgen/generator/run.py

Lines 498 to 501 in e02e6a2

else:
raise RuntimeError(
"DP-GEN currently only supports for DeePMD-kit 1.x or 2.x version!"
)

DP-GEN Version

devel

Platform, Python Version, Remote Platform, etc

No response

Input Files, Running Commands, Error Log, etc.

N/A

Steps to Reproduce

N/A

Further Information, Files, and Links

N/A
@njzjz njzjz added the bug Something isn't working label Dec 15, 2024
njzjz added a commit to njzjz/dpgen that referenced this issue Dec 19, 2024
@njzjz
fix: bump the upper bound of deepmd version
face61e 
Fix deepmodeling#1688. Though I am not sure whether we should have an upper version.
@njzjz njzjz mentioned this issue Dec 19, 2024
Merged
@njzjz njzjz linked a pull request Dec 19, 2024 that will close this issue
fix: bump the upper bound of deepmd version #1691
Merged
wanghan-iapcm pushed a commit that referenced this issue Dec 23, 2024
@njzjz
fix: bump the upper bound of deepmd version (#1691)
af4f861 
Fix #1688. Though I am not sure whether we should have an upper version.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced support for `deepmd` library versions 1.x to 3.x.
- Improved handling of model deviation tasks with refined logic for
training conditions.
- Updated file management for better input/output file linking across
tasks.

- **Bug Fixes**
	- Clarified error messages for unsupported library versions.

- **Documentation**
- Updated documentation strings for argument compatibility and function
behavior.

- **Refactor**
- Adjusted function signatures to accommodate new parameters and
improved logic.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@njzjz njzjz closed this as completed Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bump the upper bound of deepmd version njzjz/dpgen
1 participant
@njzjz