Add XML2 package and a few others to r-base-image; remove duplication in R packages targets. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
reviewed
Oct 11, 2023
r-client/Dockerfile
Outdated
| # | ||
| RUN set -eux; \ | ||
| [ "${DISTRO_BASE_SHORT}" = "fedora" ] || [ "${DISTRO_BASE_SHORT}" = "ubi" ] || exit 0; \ | ||
| . "${PREFIX}/env.sh"; \ | ||
| echo 'install.packages(c("Rcpp", "arrow", "R6", "dplyr", "testthat"), repos="http://cran.us.r-project.org", quiet=TRUE)' | \ | ||
| echo 'install.packages(c("Rcpp", "arrow", "R6", "dplyr", "testthat", "xml2"), repos="http://cran.us.r-project.org", quiet=TRUE)' | \ |
There was a problem hiding this comment.
This is a pattern-matching observation; maybe you know better than I do.
In deephaven/deephaven-core#4600 I found that the tests don't run without the "lubridate" and "zoo" packages. Since you seem to be including "testthat" here, would you also want lubridate and zoo?
There was a problem hiding this comment.
Thanks, I think I will be missing those too, so added them.
jcferretti
changed the title
kosak
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.