Monte carlo

[wushanyun64]

Add Monte carlo work flow with class mrsim_emcee.
Add a small function name_abbrev to simplify the long mrsim default param name for substream plotting. (especially correlation matrix for montecarlo).

[wushanyun64]

emcee is not recognized as a package here.

[deepanshs]

Add emcee to the requirements.txt and requirements-dev.txt files located at the root level.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (545e4dd) to head (7ad66e2).
Report is 16 commits behind head on master.

❗ Current head 7ad66e2 differs from pull request most recent head 5df1e15. Consider uploading reports for the commit 5df1e15 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           master       #81      +/-   ##
===========================================
+ Coverage   99.32%   100.00%   +0.67%     
===========================================
  Files         120       106      -14     
  Lines        8330      7345     -985     
===========================================
- Hits         8274      7345     -929     
+ Misses         56         0      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wushanyun64]

Should I also update environment.yml, environment-dev.yml files?

[deepanshs]

Yes, you will need to add it to environment.yml, environment-dev.yml files for windows build. Can you also add the tests for this code?

[wushanyun64]

Got it. Thanks Deepansh. Deepansh Srivastava ***@***.***> 于2021年8月13日周五 下午1:30写道：

…

Yes, you will need to add it to environment.yml, environment-dev.yml files for windows build. Can you also add the tests for this code? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJTIOIGVWONSFDKROUAX2V3T4VQGBANCNFSM5CBYNEHQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

-- He Sun Undergraduate Department of Chemical Physics University of Science and Technology of China 230026, Hefei, China E-Mail: ***@***.*** ***@***.***>

[wushanyun64]

Updated environment.yml, environment-dev.yml.
Added test_monte_carlo.py.

[deepanshs]

@wushanyun64 @pjgrandinetti @shyamd I see that you have a parallel set of code for naming variables, parsing variables, and chi_square function. If the reason for writing this parallel chunk of code is variable renaming, might I suggest you rename it at the end, i.e., when you generate the analysis report? Having a parallel set of code will force maintaining two sets of code and would lead to bugs. Is there any other reason behind this parallel code?

[wushanyun64]

@wushanyun64 @pjgrandinetti @shyamd I see that you have a parallel set of code for naming variables, parsing variables, and chi_square function. If the reason for writing this parallel chunk of code is variable renaming, might I suggest you rename it at the end, i.e., when you generate the analysis report? Having a parallel set of code will force maintaining two sets of code and would lead to bugs. Is there any other reason behind this parallel code?

Hi Deepansh:

By parallel set of code do you mean the name_abbrev function or methods such as minimization_function and _update_methods?

If it is the later one you mean, back when I was developing this method, Maxwell's spectral_fitting module was not in the package yet, so a lot of codes have already been written and I just keep developing based on what I have. Can we set up a phone call and discuss this?