-
Notifications
You must be signed in to change notification settings - Fork 1
chore(hooks): impl generate secrets for dvcr hook in go #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is necessary that the old ones, which are created in the python hook, are also valid here
switch { | ||
case dataFromValues.Htpasswd == "" && dataFromSecret.Htpasswd == "": | ||
input.Logger.Info("Regenerate Htpasswd") | ||
htpasswd, err := generateHtpasswd(password) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is salt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we not generate htpasswd with salt. Salt it is internal param REGISTRY_HTTP_SECRET
for dvcr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://distribution.github.io/distribution/about/configuration/
A random piece of data used to sign state that may be stored with the client to protect against tampering. For production environments you should generate a random piece of data using a cryptographically secure random generator. If you omit the secret, the registry will automatically generate a secret when it starts. If you are building a cluster of registries behind a load balancer, you MUST ensure the secret is the same for all registries.
615c9ba
to
2e53f24
Compare
2e53f24
to
52c4e91
Compare
9bc1e02
to
051dc33
Compare
Description
impl generate secrets for dvcr hook in go
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries