feat: Add polygon amoy support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const data = (await response.json()) as T | ||
| return data | ||
| } catch (error) { | ||
| console.error(error) |
There was a problem hiding this comment.
What do you think about propagating the error when it occurs?
src/lib/environment.ts
Outdated
| } | ||
|
|
||
| return isPrd || isStg ? 1 : 11155111; | ||
| })(); | ||
|
|
||
| export const peerUrl = (() => { | ||
| if (process.env.REACT_APP_PEER_URL) { | ||
| return process.env.REACT_APP_PEER_URL; | ||
| if (process.env.VITE_REACT_APP_PEER_URL) { |
There was a problem hiding this comment.
This won't be ever set, as the process.env.VITE_REACT_APP_PEER_URL must be defined in the vite config because vite does not use the process.env constant.
The same will happen with other environment variables. What do you think about adding the environments module as we have in other dApps?
cyaiox
force-pushed
the
feat/add-polygon-amoy
branch
from
ce9eb94
to
6c4bf9c
Compare
cyaiox
force-pushed
the
feat/add-polygon-amoy
branch
from
fa197a1
to
0e7fed7
Compare
.github/workflows/set-rollouts.yaml
Outdated
| @@ -24,13 +24,14 @@ jobs: | |||
| packageVersion: ${{ github.event.deployment.payload.packageVersion }} | |||
|
|
|||
| # Rollout information | |||
| deploymentDomain: "third-party-aggregator.decentraland.zone" | |||
| deploymentName: "_site" | |||
| deploymentPath: 'third-party-aggregator' | |||
There was a problem hiding this comment.
We're planning to modify the site a bit and make it more user friendly. What do you think about using the /linked-wearables path here?
There was a problem hiding this comment.
sure, it's a great idea! updated :)
LautaroPetaccio
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.