Merge pull request #21 from decentraland/fix/contract-duplicates

fix: Contract duplicates
decentraland · Aug 5, 2024 · 00c376f · 00c376f
2 parents 96b5d10 + 8c6fe5d
commit 00c376f
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/components/UpdateThirdParty/UpdateThirdPartyForm/UpdateThirdPartyForm.tsx b/src/components/UpdateThirdParty/UpdateThirdPartyForm/UpdateThirdPartyForm.tsx
@@ -71,10 +71,18 @@ const UpdateThirdPartyForm = ({ thirdParty, canUpdate, isUpdating, isThirdPartyV
           control={control}
           rules={{
             validate: (contracts: LinkedContract[]) => {
-              for (const contract of contracts) {
-                if (contracts.some(c => c.address === contract.address && c.network === contract.network)) {
-                  return 'There are duplicated contracts in the list'
-                }
+              const hasDuplicated = contracts.reduce((acc, contract, index, contracts) => {
+                return (
+                  acc ||
+                  contracts.some(
+                    (anotherContract, anotherIndex) =>
+                      anotherContract.address === contract.address && anotherContract.network === contract.network && index !== anotherIndex
+                  )
+                )
+              }, false)
+
+              if (hasDuplicated) {
+                return 'There are duplicated contracts in the list'
               }
             }
           }}