Make All Worlds Discoverable Proposal

[contribuyente]

Summary

In response to the governance proposal, Make All Worlds Discoverable On Places dApp, this pull request not only enhances the discoverability of "Worlds" in the Decentraland Places dApp but also undertakes a significant cleanup of redundant database and code infrastructure. All Worlds, irrespective of their association with LAND owners or renters, are now discoverable.

Changes

• Eliminated the hidden column from the database.
• Purged the AND hidden=false condition from the findWorld and countWorlds queries.
• Removed all occurrences and usages of the hidden property across various files.
• Deleted the user-facing disclaimer in the UI regarding the discoverability constraints of Worlds.
• Associated tasks that relied on the hidden attribute have been appropriately removed.

Impact

This updated change is a leap towards the community's vision of a more inclusive and engaging Decentraland. All Worlds are now on an even playing field, fostering a more democratic content discovery process.

Reviewers

A call for Foundation devs and proactive community members to ensure these changes meet the intent and spirit of the governance proposal. Feedback is immensely valuable to guarantee a seamless and impactful transition.

[contribuyente]

Following the positive outcome of the binding governance proposal, which garnered a significant 10M VP in favor, I'm reaching out to leading contributors of this repository, @braianj and @2fd, for a review of this pull request. If any aspects of this implementation are found lacking or misaligned, please don't hesitate to close it and take any necessary actions. Appreciate your attention and collaboration. Thank you.

[2fd]

Hi @contribuyente, thanks for contributing to the project!

The hidden feature was developed only because of the restriction we had to publish all worlds, so I will ask you to remove it entirely from the project, including the database, and to modify the database indices to prevent a regression in the performance of the queries.

To do so, you will need to:

• run the command npm run migrate create remove-hidden-prop-from-places

• using the migration of the hidden prop as guide:

  • drop the hidden column using the pgm.dropColumn function
  • drop all indices that include hidden with pgm.dropIndex
  • re-create the exact same indices without the hidded with pgm.createIndex
  • don't forget to define the down function accordingly

• remove all usage of the hidden prop from the following files:

  • src/data/placeRoad.ts
  • src/entities/Slack/utils.ts
  • src/entities/Place/types.ts
  • src/entities/World/schemas.ts
  • src/entities/Place/model.ts (the entire updateIndexWorlds method)
  • src/entities/CheckScenes/task/processContentEntityScene.ts
  • src/entities/Place/schemas.ts
  • src/data/placeGenesisPlazaWithAggregatedAttributes.ts
  • src/data/placeGenesisPlaza.ts
  • src/entities/CheckScenes/task/taskRunnerSqs.ts
  • src/entities/CheckScenes/task/taskRunnerSqs.ts

• at last, you just need to remove the task that checks for world index:

  • src/entities/World/task/processWorldsIndexing.ts.ts
  • src/entities/Place/model.test.ts
  • src/server.ts

  @braianj please add anything else you think is missing

[contribuyente]

Hi @2fd,

Thank you for the comprehensive guidance on this matter. It's clear to see why you're a core contributor, given the depth of insight you've provided here.

I understand the rationale behind the original hidden feature and the steps required to phase it out. I'll ensure that all related components are removed appropriately from the database and relevant files, and I'll attend to the indices to maintain the performance integrity of the queries.

Your clear outline makes this task straightforward, and I appreciate you taking the time to list out each and every file that needs attention.

Once I've made these changes, I'll push the updated pull request for further review. If there are any additional concerns or modifications required, don't hesitate to let me know.

[contribuyente]

Hey @2fd,

I've just pushed all the changes mentioned above. Would you please give it a look when you have a moment? Thanks 🙏 .

[braianj]

Hi @contribuyente, I just approved to run the actions but they failed. I recommend that you locally run the npm run husky-setup command before your next commit to perform the checks locally before submitting the code.
On the other hand it looks like the problem is coming from the prettier side, so I recommend you run npm run format, or you could also run npm run lint:fix.
btw, I would put in the migration the column drop after the index drops.

[contribuyente]

Hello @braianj, thank you for the feedback. I did as you said and moved the dropColumn call, also linted and setup the pre-commit hooks. I noticed some tests were failing too and I fixed them, but there are 3 test cases that fail and I don't understand the error, it doesn't seem to be related to the hidden column per se:

They are all related to this "fetcher" not being set.

[braianj]

@contribuyente It could be your node version. Please notice that the min supported version is 18.18.X. Try with that.

[contribuyente]

Hi @braianj it was indeed the node version, thank you. It seems all checks are passing now.

[braianj]

Please make those changes and we'll be go to do. Thanks!

[contribuyente]

Your suggestion has been committed @braianj 🤝

[contribuyente]

Is it okay that these two don't have the "hidden" column? They were removed in your suggested commit @braianj

[braianj]

Yes if you look when the index has been created, those don't have hidden column either, the hidden is inside the where

pgm.createIndex(PlaceModel.tableName, ["updated_at"], {
    where: "disabled is false and hidden is false and world is false",
  })
  pgm.createIndex(PlaceModel.tableName, ["like_rate"], {
    where: "disabled is false and hidden is false and world is false",
  })

[braianj]

Great job. 🚀
thank you for contributing to the project. 👍

[contribuyente]

Thank you both @2fd and @braianj 🤝 🚀