-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested Collections Listing #7384
Comments
Hi @ryangittings do you mind sharing your config for this collection (and maybe a screenshot of the file structure)? |
@ryangittings, thanks for raising this, and sorry for your trouble. This was introduced in PR #7359, which solved issue #4972. Nested collections are used in many ways, and we didn't anticipate this would impact you so severely. We also introduced this because nested collections are still flagged as beta, indicating that breaking changes are possible. We will find some time to put this feature under an opt-in flag. |
I just think it makes no sense from a visual point of view. To have one page in the pages list seems like a bug to me - if all the other pages are on the same level? The UI only ever shows one page in this setup - which fundamentally is incorrect with the tree. |
@ryangittings would you mind testing with the following cms build (built from the linked PR) and config settings:
|
@demshy this resolves the issue - yes! |
But - I'd prefer something that isn't a breaking change for all the sites I've built with Decap. |
Any update on this? It's a breaking change and I'm getting a lot of support enquiries asking why this has changed? Cheers! |
@ryangittings, we are collecting feedback on this issue to see if anyone has a similar situation to you. For now, it looks like more users are in favor of @demshy can we make this flag available on the root level also? |
@martinjagodic I can't stress how important this is for me as a decision. As you've acknowledged, this is a breaking change (even if it's a minority use case), and as such should be an opt in, rather than opt out - as it's fundamentally broken to UX of all my CMS based sites. I have lost a bit of confidence in the CMS to be honest. |
Here is my proposal (I have discussed it already with @martinjagodic): I will make a patch (will probably release today) that will make the |
the patch has been released as 3.6.2 |
Having an issue since the 3.6.0 update - it's causing nested index.md files in the collection to appear in the sidebar, rather than the main pages listing - unlike 3.5.0. This is a massive regression in my opinion.
The text was updated successfully, but these errors were encountered: