Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-7618 Implement Versioned interfaces in Transformation and Converter plugins #5363

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

harveyyue
Copy link
Contributor

@harveyyue
Copy link
Contributor Author

harveyyue commented Mar 9, 2024

@jpechane
Copy link
Contributor

@harveyyue Thank you very much for the PRs. While it is great to have the support for versioned interfaces I am not really sure about the other change introduced - centralization of the version source. The current implementation is able to detect real version based on the classloader used to load the connector. I think thi should astay as it is now. The SMTs in connectors should use appropriate Module class and the core and scripting library should intorduce its own equivalent of Module that will provide the version string.

@harveyyue
Copy link
Contributor Author

@harveyyue Thank you very much for the PRs. While it is great to have the support for versioned interfaces I am not really sure about the other change introduced - centralization of the version source. The current implementation is able to detect real version based on the classloader used to load the connector. I think thi should astay as it is now. The SMTs in connectors should use appropriate Module class and the core and scripting library should intorduce its own equivalent of Module that will provide the version string.

OK, will do it.

Copy link

Hi @harveyyue, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

1 similar comment
Copy link

Hi @harveyyue, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@jpechane jpechane merged commit 48c67e4 into debezium:main Mar 14, 2024
33 of 34 checks passed
@jpechane
Copy link
Contributor

@harveyyue Applied, thanks a lot. Should we do the same for connector classes?

@jpechane
Copy link
Contributor

Create a PR for IBMi connector - debezium/debezium-connector-ibmi#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants