From 5a02b291ff976bfd5b7352247e4e218cab08d3dc Mon Sep 17 00:00:00 2001 From: twthorn Date: Fri, 29 Mar 2024 15:59:37 -0500 Subject: [PATCH] DBZ-7698 Improve test naming --- .../connector/vitess/VitessOffsetContextTest.java | 4 ++-- .../pipeline/txmetadata/VitessEpochProviderTest.java | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/test/java/io/debezium/connector/vitess/VitessOffsetContextTest.java b/src/test/java/io/debezium/connector/vitess/VitessOffsetContextTest.java index 6adeb531..8b390da1 100644 --- a/src/test/java/io/debezium/connector/vitess/VitessOffsetContextTest.java +++ b/src/test/java/io/debezium/connector/vitess/VitessOffsetContextTest.java @@ -100,7 +100,7 @@ public void shouldResetToNewVGgtid() { } @Test - public void shouldGetOrderedTransactionContext() { + public void shouldGetVitessTransactionContext() { VitessConnectorConfig config = new VitessConnectorConfig( TestHelper.defaultConfig() .with(VitessConnectorConfig.TRANSACTION_CONTEXT, VitessTransactionContext.class) @@ -113,7 +113,7 @@ public void shouldGetOrderedTransactionContext() { } @Test - public void shouldGetInitialOrderedTransactionContext() { + public void shouldGetInitialVitessTransactionContext() { VitessConnectorConfig config = new VitessConnectorConfig( TestHelper.defaultConfig() .with(VitessConnectorConfig.TRANSACTION_CONTEXT, VitessTransactionContext.class) diff --git a/src/test/java/io/debezium/connector/vitess/pipeline/txmetadata/VitessEpochProviderTest.java b/src/test/java/io/debezium/connector/vitess/pipeline/txmetadata/VitessEpochProviderTest.java index 5a1dc34d..785698c4 100644 --- a/src/test/java/io/debezium/connector/vitess/pipeline/txmetadata/VitessEpochProviderTest.java +++ b/src/test/java/io/debezium/connector/vitess/pipeline/txmetadata/VitessEpochProviderTest.java @@ -21,7 +21,8 @@ public class VitessEpochProviderTest { private String txId = prefix + String.join(",", host1Tx2, host2Tx1); private String txIdShrunk = prefix + String.join(",", host1Tx2); - private String txIdUpgrade = "MySQL82/" + String.join(",", host1Tx2); + private String txIdVersion5 = "MySQL57/" + String.join(",", host1Tx2); + private String txIdVersion8 = "MySQL82/" + String.join(",", host1Tx2); @Test public void testGetEpochSameHostSet() { @@ -53,9 +54,9 @@ public void testGetEpochDisjointThrowsException() { } @Test - public void testGetEpochVersionUpgrade() { + public void testVersionUpgradeDoesNotAffectEpoch() { VitessEpochProvider provider = new VitessEpochProvider(); - Long epoch = provider.getEpoch(0L, previousTxId, txIdUpgrade); - assertThat(epoch).isEqualTo(1); + Long epoch = provider.getEpoch(0L, txIdVersion5, txIdVersion8); + assertThat(epoch).isEqualTo(0L); } }