Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Upgrade laravel-mix to v5.0.0 #5

Open
wahyubucil opened this issue Nov 12, 2019 · 4 comments
Open

Upgrade laravel-mix to v5.0.0 #5

wahyubucil opened this issue Nov 12, 2019 · 4 comments

Comments

@wahyubucil
Copy link
Contributor

wahyubucil commented Nov 12, 2019

I think it will be better if adonis-mix upgrade the laravel-mix to v5.0.0.

There are no breaking changes in laravel-mix v5.0.0. They're only upgrading the sass-loader to v8.0. The breaking changes only in the sass-loader itself.

I've tried to upgrade the laravel-mix version on adonis-mix and used it on my personal project. And it works well. But I need to install the new sass-loader. So maybe it will become a major update for adonis-mix.

So if adonis-mix want to upgrade the laravel-mix version, I can create a pull request for that.

But if you have some reason to not upgrade the laravel-mix, please tell me.

Thanks in advance :)

@deathman92
Copy link
Owner

Hi! No reason to upgrade. Feel free to make a PR and I'll publish new release.

@wahyubucil
Copy link
Contributor Author

Thanks. I already create a PR for that on #6

@jamesst20
Copy link

@deathman92

Is there a reason why it hasn't been merged?

@wahyubucil
Copy link
Contributor Author

Hey. I just wanna say thank you for this awesome package. It helped me a lot when using AdonisJs v4

But now, because I'm planning to use AdonisJs v5 and still need to use Laravel Mix, I'm creating Laravel Mix wrapper for AdonisJs v5. Check this out: https://npmjs.org/package/adonis-mix-asset

My package really inspires by this package. Thank you so much for this awesome package. Cheers 🍻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants