-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port preCICE example to v3 #168
Conversation
I'm sure users who would like to use precice and deal.II will at some point stumble over your code gallery program. So please adjust it in all means you find helpful for understanding the code. I second your suggestions on updating comments and changing the order of API calls. Regarding indentation: That choice is entirely up to you. I like the fact that you would like to adhere to a certain indentation style. In deal.II we currently use clang-format 16 (see here), but it's fine if you use the tools you have available. Also, feel free to take over/cherry-pick the commit from #167 to have a coherent patch. |
…alls - and adjust code comments to better reflect the proper handling of time
Thanks for the reply. Changes went now a bit bigger than anticipated, as the handling of time and time-related data becomes more explicit. I changed the Due to the changes time management, I had to update the reference/CI data as well. I verified, that all technical changes lead to the same results obtained with v2.5.0. Ready for review. |
Thank you for the updates! |
preCICE version 3 comes with a couple of breaking changes. This PR applies all changes necessary. Our porting guide still needs some clean-up, but should help with such things in the near future.
With the current changes, everything works technically and I would expect the same results as obtained with the v2.5.0 (CI ref data). However,