Shorten reference_pkg argument name to ref

[edelarua]

Closes #26

I applied this change to all functions including get_pkg_dependencies() and get_min_version_required() - is this correct? Only the *_pkg_installed() functions were specified in the issue.

[ddsjoberg]

Thank you for this PR! It looks like the other PR introduced some conflicts. Can you take a look?

[ddsjoberg]

Thinking ahead to when this is more generally used, do you think it's worthwhile to remove the default values for ref = "cards" and pkg = "cards" arguments?

[edelarua]

Thinking ahead to when this is more generally used, do you think it's worthwhile to remove the default values for ref = "cards" and pkg = "cards" arguments?

We could do that. Would it work (for most cases) if we replaced it with packageName() so the current package is used as the default?

[ddsjoberg]

Would it work (for most cases) if we replaced it with packageName() so the current package is used as the default?

OMG I love it! I did NOT know this function existed 😍

Absolutely yes, this should be the default. Can you test it in three locations and update the roxygen text with how it works in those situations?

1. Regular use inside a function I assume this is where it will work flawlessly.
2. At the top of a unit testing file. I think there is a good chance it won't work in this setting.
3. In a roxygen #' @examplesIf tag. I think there is a good chance it won't work in this setting.

If it doesn't work in either scenario 2 or 3, we should probably add a check in the function that the ref is a string with is_string(). I can imagine a situation where I forget to add the pkg name in those cases, and we should ensure the function fails.

[ddsjoberg]

@edelarua is this ready for the last review? Thanks!

[edelarua]

@edelarua is this ready for the last review? Thanks!

I think so!

[ddsjoberg]

Thank you so much!
LOVE IT!