Parallelization support via future.apply #25
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a small patch to support parallel processing for test_consequences_data_frame(). When it takes longer to calculate those stats, such as larger dataframes, more granular thresholds, and/or more models, this can have a nice speedup and I think the extra complexity is pretty minimal. For my current dataset this lets me go from 7 minutes to 45 seconds to run a dca(), so pretty helpful.
Happy to make any additional changes as preferred.
Cheers,
Chris