Python3 support. #52
Open
Python3 support. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellysmile
commented
Jan 6, 2015
hellysmile
commented
| @@ -6,6 +6,11 @@ | |||
| from django.utils.encoding import smart_unicode | |||
| except ImportError: | |||
| from django.utils.encoding import smart_text as smart_unicode | |||
| try: | |||
| from django.utils import six | |||
There was a problem hiding this comment.
do you recall which version of Django introduced this?
I'm ok with dropping support for 1.3 if i.e. it came in 1.4.
There was a problem hiding this comment.
according to
https://docs.djangoproject.com/en/dev/topics/python3/
Writing compatible code is much easier if you target Python ≥ 2.6. Django 1.5 introduces compatibility tools such as django.utils.six, which is a customized version of the six module. For convenience, forwards-compatible aliases were introduced in Django 1.4.2. If your application takes advantage of these tools, it will require Django ≥ 1.4.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.