Fix get_db_prep_value() with Unicode values, Python 2 and 3 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 30, 2014 20:21
Corrects issue where UUID value is a Unicode string for database lookup in UUIDField.get_db_prep_value(), compatible with Python 2 and 3.
Copy from peopledoc@0ba6929 (?)
Whoops! This:
```
try:
basestring
except NameError:
basestring = str
```
Will raise an UnboundLocalError (subclass of NameError) and result in the same behavior as prior to this fix. Introduced another variable to prevent this.
|
+1, just tested this and this fixes our issue. I encountered a similar issue and could test it reliably using the sqlite testsuite and these lines at the end of test_hyphenated: obj = HyphenatedUUIDField.objects.get(uuid=unicode(obj.uuid))
self.assertTrue(obj.uuid, uuid)
self.assertTrue(obj.name, 'shoe') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects issue where UUID value is a Unicode string for database lookup in UUIDField.get_db_prep_value(), compatible with Python 2 and 3.