Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip source freshness test that was skipped during troubleshooting #813

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Unskip source freshness test that was skipped during troubleshooting #813

merged 1 commit into from
Oct 26, 2023

Conversation

mikealfare
Copy link
Contributor

Problem

We skipped a test while troubleshooting recently and forgot to unskip it.

Solution

Remove the skip decorator and ensure the tests pass.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Oct 26, 2023
@mikealfare mikealfare requested a review from a team as a code owner October 26, 2023 04:12
@cla-bot cla-bot bot added the cla:yes label Oct 26, 2023
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Oct 26, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare mikealfare merged commit f1bc0ad into main Oct 26, 2023
24 of 26 checks passed
@mikealfare mikealfare deleted the tests/unskip-source-freshness-test branch October 26, 2023 17:23
@mikealfare mikealfare added the backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch label Oct 26, 2023
github-actions bot pushed a commit that referenced this pull request Oct 26, 2023
@mikealfare @github-actions
unskip test that is expected to run (#813)
b46fcca 
(cherry picked from commit f1bc0ad)
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Merged
mikealfare added a commit that referenced this pull request Oct 27, 2023
@github-actions @mikealfare
unskip test that is expected to run (#813) (#815)
5477d41 
(cherry picked from commit f1bc0ad)

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
@github-actions @mikealfare @philippe-boyd-maxa
unskip test that is expected to run (dbt-labs#813) (dbt-labs#815)
75ba8d1 
(cherry picked from commit f1bc0ad)

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit is a code owner automatically assigned from dbt-labs/adapters

Assignees

@mikealfare mikealfare

Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @colin-rogers-dbt