Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iceberg table detection #1293

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ms32035
Copy link

@ms32035 ms32035 commented Jan 22, 2025

Problem

In case the dbt project writes into multiple Snowflake databases, wrong information_schema could be queried.

Solution

Prepend the database name

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@ms32035 ms32035 requested a review from a team as a code owner January 22, 2025 16:30
Copy link

cla-bot bot commented Jan 22, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @ms32035

@ms32035
Copy link
Author

ms32035 commented Jan 22, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Jan 22, 2025
Copy link

cla-bot bot commented Jan 22, 2025

The cla-bot has been summoned, and re-checked this pull request!

@colin-rogers-dbt
Copy link
Contributor

@ms32035 can you add a changelog entry? If you have it installed you can just run changie new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants