Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new params to quiet mypy, a type ignore doesn't work. #1278

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Dec 18, 2024

Problem

mypy error. https://github.com/dbt-labs/dbt-snowflake/actions/runs/12392976123

Solution

add the params as options to match superclass signature

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Dec 18, 2024
@cla-bot cla-bot bot added the cla:yes label Dec 18, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

1 similar comment
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Dec 18, 2024
@colin-rogers-dbt colin-rogers-dbt merged commit 41e3205 into 1.8.latest Dec 18, 2024
31 of 33 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the fix_code_quality_test branch December 18, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants