Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Refresh mode for dynamic tables #1086

Closed
3 tasks done
matsavage opened this issue Jun 17, 2024 · 4 comments
Closed
3 tasks done

[Feature] Refresh mode for dynamic tables #1086

matsavage opened this issue Jun 17, 2024 · 4 comments
Labels
duplicate enhancement New feature or request

Comments

@matsavage
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

When working with dynamic tables, there is no option to specify the "refresh mode" for the table on creation, which is something we would like to do with our models.

https://docs.snowflake.com/en/sql-reference/sql/create-dynamic-table

This is useful to us, as some of our tables are not automatically "INCREMENTAL" refresh and fall-back to "FULL", and we would like to override this

Describe alternatives you've considered

Looked at a pre-hook to generate a table, but this is very unsatisfactory

Who will this benefit?

Users of Dynamic tables in Snowflake

Are you interested in contributing this feature?

No response

Anything else?

I don't think this is a huge piece of functionality to add, but it feels like there is a lot of overhead wrt complexity of the project and getting an environment set up to test.

@matsavage matsavage added enhancement New feature or request triage labels Jun 17, 2024
@matsavage
Copy link
Author

I have added a (draft) PR with the bulk of the changes, but access to a non-work, non-locked down instance of snowflake to test against will be a hinderance from here.

@jtcohen6
Copy link
Contributor

Hey @matsavage - thanks for the issue! I think we've already got some work in flight to address this:

As a continuation of this past issue / community PR:

If you want to give that branch a try, before we merge & release:

pip install git+https://github.com/dbt-labs/dbt-snowflake.git@dynamic-table-parameters

@jtcohen6 jtcohen6 removed the triage label Jun 17, 2024
@jtcohen6
Copy link
Contributor

I'm going to close this issue, as I believe it's a duplicate with the ones linked above, but please let me know if you disagree!

@jtcohen6 jtcohen6 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
@matsavage
Copy link
Author

Thanks, this looks like it does it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants