diff --git a/.changes/unreleased/Dependencies-20240403-134607.yaml b/.changes/unreleased/Dependencies-20240403-134607.yaml new file mode 100644 index 000000000..ccc80c5e9 --- /dev/null +++ b/.changes/unreleased/Dependencies-20240403-134607.yaml @@ -0,0 +1,6 @@ +kind: Dependencies +body: Add `dbt-core` as a dependency to preserve backwards compatibility for installation +time: 2024-04-03T13:46:07.335865-04:00 +custom: + Author: mikealfare + PR: "756" diff --git a/setup.py b/setup.py index 234e7c97d..4673657b8 100644 --- a/setup.py +++ b/setup.py @@ -65,6 +65,8 @@ def _plugin_version_trim() -> str: # dbt-redshift depends deeply on this package. it does not follow SemVer, therefore there have been breaking changes in previous patch releases # Pin to the patch or minor version, and bump in each new minor version of dbt-redshift. "redshift-connector<2.0.918,>=2.0.913,!=2.0.914", + # add dbt-core to ensure backwards compatibility of installation, this is not a functional dependency + "dbt-core>=1.8.0a1", # installed via dbt-core but referenced directly; don't pin to avoid version conflicts with dbt-core "sqlparse>=0.2.3,<0.5", "agate", diff --git a/tests/functional/adapter/test_query_comment.py b/tests/functional/adapter/test_query_comment.py index db6a440d7..75c87ee38 100644 --- a/tests/functional/adapter/test_query_comment.py +++ b/tests/functional/adapter/test_query_comment.py @@ -6,6 +6,7 @@ BaseNullQueryComments, BaseEmptyQueryComments, ) +import pytest class TestQueryCommentsRedshift(BaseQueryComments): @@ -17,7 +18,12 @@ class TestMacroQueryCommentsRedshift(BaseMacroQueryComments): class TestMacroArgsQueryCommentsRedshift(BaseMacroArgsQueryComments): - pass + @pytest.mark.skip( + "This test is incorrectly comparing the version of `dbt-core`" + "to the version of `dbt-postgres`, which is not always the same." + ) + def test_matches_comment(self, project, get_package_version): + pass class TestMacroInvalidQueryCommentsRedshift(BaseMacroInvalidQueryComments):