Skip to content

Commit

Permalink
Add dbt-core~=1.8.0a1 as convenience dep (#756)
Browse files Browse the repository at this point in the history
* add `dbt-core~=1.8.0a1` as convenience dep
* skip inapplicable version comparison test
  • Loading branch information
mikealfare authored Apr 3, 2024
1 parent 3483ad1 commit 3e9e948
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .changes/unreleased/Dependencies-20240403-134607.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Dependencies
body: Add `dbt-core` as a dependency to preserve backwards compatibility for installation
time: 2024-04-03T13:46:07.335865-04:00
custom:
Author: mikealfare
PR: "756"
2 changes: 2 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ def _plugin_version_trim() -> str:
# dbt-redshift depends deeply on this package. it does not follow SemVer, therefore there have been breaking changes in previous patch releases
# Pin to the patch or minor version, and bump in each new minor version of dbt-redshift.
"redshift-connector<2.0.918,>=2.0.913,!=2.0.914",
# add dbt-core to ensure backwards compatibility of installation, this is not a functional dependency
"dbt-core>=1.8.0a1",
# installed via dbt-core but referenced directly; don't pin to avoid version conflicts with dbt-core
"sqlparse>=0.2.3,<0.5",
"agate",
Expand Down
8 changes: 7 additions & 1 deletion tests/functional/adapter/test_query_comment.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
BaseNullQueryComments,
BaseEmptyQueryComments,
)
import pytest


class TestQueryCommentsRedshift(BaseQueryComments):
Expand All @@ -17,7 +18,12 @@ class TestMacroQueryCommentsRedshift(BaseMacroQueryComments):


class TestMacroArgsQueryCommentsRedshift(BaseMacroArgsQueryComments):
pass
@pytest.mark.skip(
"This test is incorrectly comparing the version of `dbt-core`"
"to the version of `dbt-postgres`, which is not always the same."
)
def test_matches_comment(self, project, get_package_version):
pass


class TestMacroInvalidQueryCommentsRedshift(BaseMacroInvalidQueryComments):
Expand Down

0 comments on commit 3e9e948

Please sign in to comment.