-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate dbt_yml_files from pydantic classes #150
Closed
aliceliu
wants to merge
17
commits into
main
from
07-24-generate_dbt_yml_files_from_pydantic_classes
Closed
Generate dbt_yml_files from pydantic classes #150
aliceliu
wants to merge
17
commits into
main
from
07-24-generate_dbt_yml_files_from_pydantic_classes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliceliu
force-pushed
the
07-24-generate_dbt_yml_files_from_pydantic_classes
branch
from
July 25, 2024 19:55
eb115ad
to
6484bab
Compare
Closing in favor of #159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated pydantic classes from existing jsonschema using
datamodel-codegen --input /Users/alicejliu/git/dbt-jsonschema/schemas/latest/dbt_yml_files-latest.json --input-file-type jsonschema --output model.py --output-model-type=pydantic_v2.BaseModel --target-python-version=3.11 --use-title-as-name --field-constraints
However there are if/then/not statements in the jsonschema that cannot be translated to Pydantic. For those I manually fixed them:
There were also a couple of other manual fixes I had to make: