Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt init create project in current dir #9268

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lllong33
Copy link
Contributor

@lllong33 lllong33 commented Dec 11, 2023

resolves #8216

image

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@lllong33 lllong33 requested a review from a team as a code owner December 11, 2023 01:56
@lllong33 lllong33 requested a review from emmyoop December 11, 2023 01:56
Copy link

cla-bot bot commented Dec 11, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: lllong33.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.66%. Comparing base (c2bc2f0) to head (fb76550).
Report is 127 commits behind head on main.

Files Patch % Lines
core/dbt/task/init.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9268      +/-   ##
==========================================
- Coverage   86.71%   86.66%   -0.06%     
==========================================
  Files         179      179              
  Lines       26648    26649       +1     
==========================================
- Hits        23108    23095      -13     
- Misses       3540     3554      +14     
Flag Coverage Δ
integration 83.54% <94.44%> (-0.14%) ⬇️
unit 65.10% <16.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lllong33
Copy link
Contributor Author

I saw this error in test_init.py. It seems that the modification is not so simple. I need to take some time to look at it

Copy link

cla-bot bot commented Dec 14, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: lllong33.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Dec 14, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: lllong33.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@dbeatty10 dbeatty10 added the community This PR is from a community member label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2873] [Feature] dbt init should create project in current dir (.) instead of creating a new dir
2 participants