Env vars to override DB connection #748
Draft
+29
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianl15
reviewed
Feb 6, 2025
src/dbos-runtime/config.ts
Outdated
| configFile['database']['local_suffix'] = | ||
| configFile['database']['local_suffix'] || databaseConnection['local_suffix'] || false; | ||
| configFile.database.hostname = | ||
| process.env.DBOS_DBHOST ?? configFile.database.hostname ?? databaseConnection.hostname ?? 'localhost'; |
There was a problem hiding this comment.
Why did we change to ?? (nullish coalescing) instead of || (the OR operator)? I think the benefit of || is that if the env variable is set to an empty string, it will consider to be not set. Otherwise, we might get some empty string variables.
There was a problem hiding this comment.
OK, will change it back
devhawk
commented
Feb 6, 2025
| process.env.PGPASSWORD ?? | ||
| 'dbos'; | ||
| const dbos_dblocalsuffix = process.env.DBOS_DBLOCALSUFFIX ? process.env.DBOS_DBLOCALSUFFIX === 'true' : undefined; | ||
| configFile.database.local_suffix = |
There was a problem hiding this comment.
Note, using || for boolean | undefined values is probably not what we want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.