Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test & Improve Queue Semantics #747

Merged
merged 22 commits into from
Feb 6, 2025
Merged

Test & Improve Queue Semantics #747

merged 22 commits into from
Feb 6, 2025

Conversation

kraftp
Copy link
Member

@kraftp kraftp commented Feb 5, 2025

  • Cancelling a workflow removes it from any queue it is in. This way, cancelled workflows don't block queues.
  • Resume sets status to PENDING and resets recovery attempts. It also removes the workflow from any queue it is in. This way, resume can safely start DLQ'ed, CANCELLED, and ENQUEUED workflows.
  • Lots and lots of tests.

@kraftp kraftp marked this pull request as ready for review February 5, 2025 22:35
src/httpServer/server.ts Show resolved Hide resolved
tests/helpers.ts Show resolved Hide resolved
tests/httpServer/adminserver.test.ts Outdated Show resolved Hide resolved
@kraftp kraftp merged commit c8579d8 into main Feb 6, 2025
5 checks passed
@kraftp kraftp deleted the kraftp/queue-semantics branch February 6, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants