remove explicit notion of recovery #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdml
commented
Feb 3, 2025
tests/recovery.test.ts
Outdated
Comment on lines
96
to
99
| for (let i = 0; i < LocalRecovery.maxRecoveryAttempts * 2; i++) { | ||
| await testRuntime.startWorkflow(LocalRecovery, handle.getWorkflowUUID()).deadLetterWorkflow(); | ||
| expect(LocalRecovery.recoveryCount).toBe(i + LocalRecovery.maxRecoveryAttempts + 1); | ||
| } |
There was a problem hiding this comment.
This path does not make sense anymore (you can't call a workflow in "non recovery mode")
maxdml
commented
Feb 4, 2025
| for (let i = 0; i < 10; i++) { | ||
| await testRuntime.startWorkflow(DBOSTestClass, handle.getWorkflowUUID()).noopWorkflow(); | ||
| const result = await systemDBClient.query<{status: string, attempts: number}>(`SELECT status, recovery_attempts as attempts FROM dbos.workflow_status WHERE workflow_uuid=$1`, [handle.getWorkflowUUID()]); | ||
| expect(result.rows[0].attempts).toBe(String(i + 2)); |
There was a problem hiding this comment.
+2 because:
- +1 for the first call to
startWorkflowabove - +1 because i starts at 0
kraftp
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the logic for putting a workflow in the dead letter queue. Specifically, it changes the meaning of the
recovery_attemptcolumn in thedbos.workflow_statustable toattempts*.The default of the column is now 1.
Callers of
init_workflow_statusdo not need to specify whether the workflow is being recovered.init_workflow_statusjust verifies that(number of attempts) <= max_retriesbefore placing a workflow in the DLQ.[*] This PR does not change the column name, to facilitate backward compatibility.