Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Database Connection Parameter Management #182

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Conversation

kraftp
Copy link
Member

@kraftp kraftp commented Jan 21, 2025

  • Remove database connection parameters from dbos-config.yaml by default (though they can still be there)
  • Instead, read and store database connection parameters in a hidden local file, .dbos/db_connection, which is not committed to version control.
  • If no connection parameters are given, use local connection defaults.
  • Clearly print where database connection parameters are being read from at DBOS startup.

@kraftp kraftp merged commit dc5c4c6 into main Jan 22, 2025
5 checks passed
@kraftp kraftp deleted the kraftp/db-connection branch January 22, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants