Shop test #111
Merged
Shop test #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianl15
reviewed
Feb 20, 2024
| ): Promise<void> { | ||
| ): Promise<void> | ||
| { | ||
| if (webhook === "http://fakehost/webhook") { |
There was a problem hiding this comment.
In the operations.test.ts, can we try to use spyOn for the fetch call?
There was a problem hiding this comment.
Like this:
const fetchMock = jest
.spyOn(global, 'fetch')
.mockImplementation(() =>
Promise.resolve({ json: () => Promise.resolve([]) })
)
There was a problem hiding this comment.
I was going to illustrate both ways. I think it is fair to have some provision for behaviors that occur only in test mode, as mocks can get very complicated and almost as hard to debug as the real code.
qianl15
reviewed
Feb 20, 2024
qianl15
reviewed
Feb 20, 2024
qianl15
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.