Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fail-on-error to fail-level #308

Closed
wants to merge 2 commits into from

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Jan 25, 2025

-fail-on-error is deprecated. see reviewdog/reviewdog@v0.20.1...v0.20.2

@legoguy1000 legoguy1000 changed the title Update entrypoint.sh Change fail-on-error to fail-level Jan 25, 2025
@legoguy1000 legoguy1000 marked this pull request as ready for review January 25, 2025 18:11
@dbelyaev dbelyaev self-assigned this Jan 27, 2025
@dbelyaev
Copy link
Owner

Hello, @legoguy1000!

Thank you for your contribution and for taking the time to share it.

I wasn't aware of this deprecation, so I appreciate you bringing it to light.

To adhere to conventional commits and to update the documentation (specifically, to add the fail-level related notes and remove the deprecated parameter), I had to modify the commit message. Therefore, I recreated your contribution in a branch within this repository to allow the addition of some extra commits (see PR #309, your origin of the commits, of course, has been preserved).

Additionally, I adjusted the default value from error, as you initially suggested, to none, aligning it with what reviewdog defaults to in their CLI version. This change is intended to prevent any disruptions in the pipelines for users who use this action. I hope you understand and agree with this approach.

@legoguy1000
Copy link
Contributor Author

Hello, @legoguy1000!

Thank you for your contribution and for taking the time to share it.

I wasn't aware of this deprecation, so I appreciate you bringing it to light.

To adhere to conventional commits and to update the documentation (specifically, to add the fail-level related notes and remove the deprecated parameter), I had to modify the commit message. Therefore, I recreated your contribution in a branch within this repository to allow the addition of some extra commits (see PR #309, your origin of the commits, of course, has been preserved).

Additionally, I adjusted the default value from error, as you initially suggested, to none, aligning it with what reviewdog defaults to in their CLI version. This change is intended to prevent any disruptions in the pipelines for users who use this action. I hope you understand and agree with this approach.

All good, however it looks like the bash script is still using the old input?

-fail-on-error="${INPUT_FAIL_ON_ERROR:-false}" \

@dbelyaev
Copy link
Owner

All good, however it looks like the bash script is still using the old input?

-fail-on-error="${INPUT_FAIL_ON_ERROR:-false}" \

Thank you again! My bad, this has been corrected now and released as version v1.17.1.

@dbelyaev
Copy link
Owner

Closing this PR as resolved in #309 and #312.

@dbelyaev dbelyaev closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants