Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token name "Border Height" irritating as CSS class for size of border is "border-width". #189

Open
niklaslankenau-dbsystel opened this issue Jan 8, 2025 · 2 comments
Open

Token name "Border Height" irritating as CSS class for size of border is "border-width". #189

niklaslankenau-dbsystel opened this issue Jan 8, 2025 · 2 comments
Labels
👩‍👧‍👦 community feedback Feedback from community 📕 documentation Improvements or additions to documentation 📦 foundations This issue affects the foundation

Comments

@niklaslankenau-dbsystel
Copy link

Link

https://marketingportal.extranet.deutschebahn.com/marketingportal/Design-Anwendungen/db-ux-design-system/version-3/foundation/border-height

Description

Ist es irritierend, wenn Strichstärke einer Border in DBUX als "db-border-height" definiert wird, jedoch die CSS Klasse dafür "border-width" heißt?

Geht es um Höhe oder Breite?

Suggestion/Example

  • Border Width
  • Border Strength
  • Border Thickness

Bildschirmfoto 2025-01-08 um 15 21 42
@niklaslankenau-dbsystel niklaslankenau-dbsystel added the 📕 documentation Improvements or additions to documentation label Jan 8, 2025
@leape
Copy link
Contributor

leape commented Jan 14, 2025

@nmerget any opinion on this?

@leape leape added 👩‍👧‍👦 community feedback Feedback from community 📦 foundations This issue affects the foundation labels Jan 14, 2025
@nmerget
Copy link
Collaborator

nmerget commented Jan 30, 2025

@nmerget any opinion on this?

I would name it border-width as well, as I thought it would make more sense for designers. But if this isn't the case, let's rename it

@leape leape added 💬 assessment We need 2 talk about it and removed 💬 assessment We need 2 talk about it labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👩‍👧‍👦 community feedback Feedback from community 📕 documentation Improvements or additions to documentation 📦 foundations This issue affects the foundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leape @niklaslankenau-dbsystel @nmerget