Fix deprecation of implicit nullable parameter declarations. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great thanks - these are recent (post 4.4 release) changes to the code checking sniffs, so weren't covered by my initial upgrade. They were vaguely on my radar to look at some time, so thanks for providing the fixes now. I'll try to review over the weekend - a quick glance suggests they look good, but I always like to read code carefully before I hit 'merge'. |
|
Apologies - life was busy for the last month, but I've reviewed this now and merged it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those amendments let Moodle codechecker run through; they also check for Moodle 4.4 and PHP 8.3.