fix: Handle race conditions when getting the compiler bridge #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was identified in davidB#738 that a race condition could occur when building a project using multiple threads. To mitigate the issue, I wrapped the installation of the compiler with a synchronized block on the Static instance. As a result, if multiple threads try to install the compiler at the same time, only one thread will be able to do so. When they will get unlocked, it will check if the file was created meanwhile and if so, to will early return.
slandelle
approved these changes
Apr 23, 2024
|
@slandelle When can we expect a release? I also noticed that the latest versions are not available on maven central |
|
As soon as I manage to fix the release. I suspect maven-gpg-plugin has changed the way things work... |
|
4.9.0 is online |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was identified in #738 that a race condition could occur when building a project using multiple threads.
To mitigate the issue, I wrapped the installation of the compiler with a synchronized block on the Static instance.
As a result, if multiple threads try to install the compiler at the same time, only one thread will be able to do so. When they will get unlocked, it will check if the file was created meanwhile and if so, to will early return.